-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s] Use images.csv
catalog to get container image tags
#2556
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
"""Kubernetes Catalog. | ||
|
||
Kubernetes does not require a catalog of instances, but we need an image catalog | ||
mapping SkyPilot image tags to corresponding container image tags. | ||
""" | ||
|
||
from typing import Optional | ||
|
||
from sky.clouds.service_catalog import common | ||
|
||
_PULL_FREQUENCY_HOURS = 7 | ||
|
||
# We keep pull_frequency_hours so we can remotely update the default image paths | ||
_image_df = common.read_catalog('kubernetes/images.csv', | ||
pull_frequency_hours=_PULL_FREQUENCY_HOURS) | ||
|
||
# TODO(romilb): Refactor implementation of common service catalog functions from | ||
# clouds/kubernetes.py to kubernetes_catalog.py | ||
|
||
|
||
def get_image_id_from_tag(tag: str, region: Optional[str]) -> Optional[str]: | ||
"""Returns the image id from the tag.""" | ||
return common.get_image_id_from_tag_impl(_image_df, tag, region) | ||
|
||
|
||
def is_image_tag_valid(tag: str, region: Optional[str]) -> bool: | ||
"""Returns whether the image tag is valid.""" | ||
return common.is_image_tag_valid_impl(_image_df, tag, region) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, they are still container image tags (e.g.,
ubuntu:latest
), since container image ids are hex values and are typically not used to specify images to use.