Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add native docker support doc #2560

Merged
merged 6 commits into from
Sep 16, 2023
Merged

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Sep 14, 2023

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@romilbhardwaj romilbhardwaj added this to the 0.4 milestone Sep 15, 2023
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cblmemo! I pushed some changes - if all looks good to you we can go ahead and merge this.

@cblmemo
Copy link
Collaborator Author

cblmemo commented Sep 16, 2023

Thanks @cblmemo! I pushed some changes - if all looks good to you we can go ahead and merge this.

Fixed a typo in the doc. Thanks for the help! ;)

@romilbhardwaj romilbhardwaj merged commit 7c61c94 into master Sep 16, 2023
@romilbhardwaj romilbhardwaj deleted the native-docker-doc branch September 16, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants