Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add minimal permission for reserve instances #2569

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[Docs] Add minimal permission for reserve instances #2569

merged 1 commit into from
Sep 18, 2023

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Sep 18, 2023

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

romilbhardwaj
romilbhardwaj approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cblmemo!

@cblmemo cblmemo merged commit 6f9ad6b into master Sep 18, 2023
@cblmemo cblmemo deleted the reservation-minimal branch September 18, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romilbhardwaj romilbhardwaj romilbhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cblmemo @romilbhardwaj