[Provisioner] Fix bug when using docker login config and launching without yaml #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Sep 18, 2023
sky/task.py
Outdated
Comment on lines
475
to
476
| # NOTE(dev): This should be called before task.set_resources() because | ||
| # of the docker login config. |
There was a problem hiding this comment.
Should we instead, at the end of set_env call the _with_docker_login_config if we find the docker login config in the new envs, so we don't have to requiring the set_envs to be called before set_resources?
There was a problem hiding this comment.
Good point! Done. Thanks!
sky/cli.py
Outdated
| @@ -1425,6 +1425,7 @@ def launch( | |||
| '`sky spot launch`. `sky launch` supports a ' | |||
| 'single task only.') | |||
| task = task_or_dag | |||
| print(task) | |||
There was a problem hiding this comment.
Yeah... Some remnant of debug 😔 Thanks for pointing that out!
Michaelvll
approved these changes
Sep 18, 2023
Comment on lines
+508
to
+510
| if _check_docker_login_config(self._envs): | ||
| self.resources = _with_docker_login_config(self.resources, | ||
| self._envs) |
There was a problem hiding this comment.
Add a comment for why we are doing this?
Michaelvll
reviewed
Sep 18, 2023
Co-authored-by: Zhanghao Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh