[Docs] Update docker container doc #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romilbhardwaj
approved these changes
Sep 18, 2023
|
|
||
| .. code-block:: yaml | ||
|
|
||
| # private_docker.yaml | ||
| # ecr_private_docker.yaml | ||
| resources: | ||
| image_id: docker:<your-private-image>:<tag> |
There was a problem hiding this comment.
If you're giving a concrete example, might as well also update this to something concrete:
Suggested change
| image_id: docker:<your-private-image>:<tag> | |
| image_id: docker:<your-user-id>.dkr.ecr.us-east-1.amazonaws.com/your-private-image:latest |
There was a problem hiding this comment.
Oh actually we only require users to specify your-private-image in the image_id section... See here
There was a problem hiding this comment.
I see the confusion. Maybe we could support both? Let me raise an PR to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docker container doc by:
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh