Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SkyServe] Fix sky serve down --purge when storage cleanup failed #2576

Closed
wants to merge 1 commit into from
Closed

[SkyServe] Fix sky serve down --purge when storage cleanup failed #2576

wants to merge 1 commit into from

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Sep 18, 2023

Fixes #2566 .

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@MaoZiming
Copy link
Collaborator

MaoZiming commented Sep 18, 2023 •
edited
Loading

Nice PR. Looks good to me

@cblmemo
Copy link
Collaborator Author

cblmemo commented Nov 16, 2023

Closed due to #2458 merged.

@cblmemo cblmemo closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cblmemo @MaoZiming