New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SkyServe] Fix FastAPI #2739

Closed

cblmemo wants to merge 1 commit into serve from serve-fix-fastapi

Collaborator

cblmemo commented Oct 27, 2023

The current implementation will cause the controller FastAPI to hang after ~1mo. This PR fixed the issue.

Reference: fastapi/fastapi#1728 (comment)

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

fix

1589ee1

Collaborator Author

cblmemo commented Nov 16, 2023

Closed due to #2458 merged.

cblmemo closed this

Michaelvll deleted the serve-fix-fastapi branch

December 18, 2024 19:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet