Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4.1 #2741

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Release 0.4.1 #2741

merged 3 commits into from
Oct 29, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Oct 27, 2023

  • pytest tests/test_smoke.py
  • pytest tests/test_smoke.py --aws
  • locally build docs, open docs/build/index.html, scroll over “CLI Reference” (ideally, every page) to see if there are missing sections (we once caught the CLI page completely missing due to an import error; and once it has weird blockquotes displayed)
  • Check sky -v
  • backward_compatibility_tests.sh run against 0.4.0.
  • Run manual stress tests (see subsection below)
    • following script
      sky spot launch --gpus A100:8 --cloud aws echo hi -y
      # Check we are properly failing over the zones:
      sky spot logs --controller
      
    • following script
      sky launch -c dbg --cloud aws --num-nodes 16 --cpus 2+ --down echo hi  # without timeout bump
      sky down dbg  
      
    • following script
      sky launch -c dbg --cloud aws --num-nodes 16 --gpus T4 --down --use-spot echo hi
      sky down dbg
      
    • following script (16 nodes do not work with GCP due to the autoscaler bug of ray)
      sky launch -c dbg --cloud gcp --num-nodes 8 --cpus 2+ --down  echo hi# with or without timeout bump
      sky down dbg  
      
    • following script
      # Run a 24-hour+ spot job and ensure it doesn’t OOM
      # https://github.com/skypilot-org/skypilot/pull/2675
      sky spot launch -n test-oom --cloud aws --cpus 2 sleep 86400
      

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll changed the title 0.4.1 version/commit Release 0.4.1 Oct 27, 2023
* Fix file mounts

* print out the skylet version for better debugging ability

* Add skypilot version
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Michaelvll Michaelvll merged commit fec2b31 into releases/0.4.1 Oct 29, 2023
18 checks passed
@Michaelvll Michaelvll deleted the 0.4.1 branch October 29, 2023 20:59
Michaelvll added a commit that referenced this pull request Oct 29, 2023
* [Provisioner] Fix cache for internal file mounts (#2715)

* Fix file mounts

* print out the skylet version for better debugging ability

* Add skypilot version

* 0.4.1 version/commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants