Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency] Update google-api-python-client version for discardLocalSsd #2759

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Nov 6, 2023

Fixes #2757

Reference: googleapis/google-api-python-client@f6e9d38

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@concretevitamin
Copy link
Member

Can confirm after upgrading to

Successfully installed google-api-python-client-2.106.0

sky stop my-gcp-cluster works properly now.

@cblmemo
Copy link
Collaborator

cblmemo commented Nov 6, 2023

@Michaelvll Michaelvll merged commit d1a8f26 into master Nov 10, 2023
18 checks passed
@Michaelvll Michaelvll deleted the gcp-api-client-version branch November 10, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sky stop a GCP cluster throws Got an unexpected keyword argument discardLocalSsd
3 participants