[SkyServe] CLI args for task option and service config override for sky serve up

[cblmemo]

This PR adds task option and service config override for sky serve up.

Tested (run the relevant ones):

• Code formatting: bash format.sh
• Any manual or new tests for this PR (please specify below)
  • sky serve up 'python -m http.server 8080' --readiness-path / --initial-delay-seconds 120 --min-replicas 1 --ports 8080 -n test-cli-service
• All smoke tests: pytest tests/test_smoke.py
• Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
• Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

[concretevitamin]

A user bumped for this wanting --env.

[MaoZiming]

I am wondering if we can refactor out this common pattern

    if field is not None:
         if field.lower() == 'none':
             resources_override_params['field_str'] = None
         else:
             resources_override_params['field_str'] = field

[cblmemo]

This is a little bit tricky since some fields like clouds need special handling; Lets do this in another PR?

[MaoZiming]

sg.

[MaoZiming]

_make_task_or_dag_from_entrypoint_with_overrides a bit confusing here where the services overrides do not apply to dag with multiple tasks.

[cblmemo]

_make_task_or_dag_from_entrypoint_with_overrides a bit confusing here where the services overrides do not apply to dag with multiple tasks.

Thanks for pointing it out! Actually, we don't need to do this check since skyserve doesn't support chain dag; ref

skypilot/sky/cli.py

Lines 4283 to 4285 in 6fd5bf2

	if isinstance(task, sky.Dag):
	raise click.UsageError(
	_DAG_NOT_SUPPORTED_MESSAGE.format(command='sky serve up'))

Just removed the check.

[MaoZiming]

Thanks for the quick fix. Please do more manual tests before merging : )

[Michaelvll]

Thanks for adding CLI arguments for sky serve @cblmemo! Left a comment below.

[Michaelvll]

I am not exactly sure about having these service related arguments in the CLI as they might be a bit too detailed for a service. Can we leave them out for now (e.g., keep them in another branch), and only merge the CLI arguments for resources for sky serve CLI?

[cblmemo]

Good point! Done in #2979 and PTAL

[github-actions]

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.