-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update dependencies for docs #2919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, any major differences in the rendered HTML?
Thanks @Michaelvll! Things I like:
Minor feedback (not necessary to fix, but nice to have): Colors
Is it possible to use the older color scheme? TOC at the bottom of the landing pageRefer to image below. Left is new, right is old. The new one seems a little dense - any way to add more space there? |
Hey @romilbhardwaj, thank you for the suggestions! I have reverted the code style to the original theme, and changed the hover color to the same color as the original one. For the TOC, I could not find a easy way to increase the space. Should we merge this PR first and then figure out a way to fix that? : ) We can find the preview version here: https://skypilot.readthedocs.io/en/update-docs-dependency/ |
This new version looks great! A few nits to see if there are knobs to get rid of them:
This is not the case for the current UI.
|
Thanks for the suggestions! I fixed all of them. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Michaelvll!
This is following the docs dependency update by https://github.com/ray-project/ray/releases/tag/ray-2.9.0
This PR also fixes the dark mode.
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh