Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkyServe] Support GPU Heterogeneity Policy #2927

Closed
wants to merge 32 commits into from

Conversation

landscapepainter
Copy link
Collaborator

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@landscapepainter landscapepainter marked this pull request as draft December 31, 2023 06:59
"""Terminate the sky serve replica cluster."""
time.sleep(delay_in_s)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we set delay_in_s to? Do we need this in addition the the scale-down delay we already have?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is for draining I'm guessing? To make sure ongoing requests are routed to new instance?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. This is a experimental feature from the spot policy branch. And @MaoZiming mentioned that some more discussion needs to be done weather or not to keep this time.sleep()

Copy link
Contributor

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Copy link
Contributor

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Sep 25, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants