Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Use storage.admin permission for automatically created skypilot-v1 service account #2947

Merged
merged 3 commits into from
Jan 14, 2024
Merged

[GCP] Use storage.admin permission for automatically created skypilot-v1 service account #2947

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ee4e34
Change the permission for skypilot-v1 service account to storage.admi…
Michaelvll Jan 6, 2024
0bc7e63
Avoid show-gpus depending on GpuInfo
Michaelvll Jan 6, 2024
3d0b899
Revert to GpuInfo
Michaelvll Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sky/provision/gcp/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
# NOTE: `serviceAccountUser` allows the head node to create workers with
# a serviceAccount. `roleViewer` allows the head node to run bootstrap_gcp.
DEFAULT_SERVICE_ACCOUNT_ROLES = [
'roles/storage.objectAdmin',
'roles/storage.admin',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old sky/skylet/providers/gcp/config.py has this too, should it be changed (or should that dir be removed)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dir should be removed now. Also, the AWS node provider should be removed as well #2792. We will handle that in another PR.

'roles/compute.admin',
'roles/iam.serviceAccountUser',
'roles/iam.roleViewer',
Expand Down