-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add warning against installing Ray in base environment #3267
Merged
Michaelvll
merged 11 commits into
skypilot-org:master
from
MysteryManav:docs/multiple-ray-warning
Mar 14, 2024
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c281c0d
Docs: Add warning against installing Ray in base environment
MysteryManav bf601db
Docs: Add warning against installing Ray in base environment
MysteryManav 8f6f7ae
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav 1f3b63f
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav a132beb
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav 0b77d56
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav 306c7f3
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav 4cf16b0
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav 86596e4
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav 7d69735
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav 683f103
Update docs/source/running-jobs/distributed-jobs.rst
MysteryManav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For discussion: We may want to add a dedicated guide on how to use Ray as part of the user job. That page can use a tip like this. A full YAML example #3195 may help promote this recommendation more directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let’s add a yaml example of starting a distributed job with ray as mentioned above. We can try to move it to a separate page later after this pr is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for confirmation: I should add the command to run the example in distributed_ray_train, the one that uses FashionMNIST and add the command for tha yaml file and its output as example in the documentation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can add the yaml file inline with the command to run that yaml : )