-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Rclone to Cache Storage #3455
Conversation
* fix permissions * fix permissions
* Add serve for gemma and fix mixtral dependency * Add hf token * fix model len * Add comment * Serve your private gemma * fix serve yaml * readme * Remove chat completion due to the wrong template * add readme * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <[email protected]> * address comments * Update README.md Co-authored-by: Zongheng Yang <[email protected]> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <[email protected]> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <[email protected]> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <[email protected]> * Change to it * Add chat API * use HF_TOKEN env * typo --------- Co-authored-by: Zongheng Yang <[email protected]>
* when removing cudo credential, sky check fails * remove tips * minor hint fix * fix cluster version for k8s * fix typo
…org#3218) * Add retry for docker pull due to daemon not ready * longer wait time * longer wait time * retry earlier * add retry for retries as well * longer wait time * change wait time * format * Add comment * Fix * Fix indent for azure docker config * Fix docker login config * Fix comments * More robust docker login config * Add retry for docker check * minor fix * Add additional test for stop and start with docker * Fix cancelled
…o hriday/unsloth # Conflicts: # README.md # docs/source/index.rst
name: {{storage_name}} | ||
source: ~/tmp-workdir | ||
store: {{store_type}} | ||
mode: RCLONE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this new mode, or should we directly change the behavior of MOUNT
to rclone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed online, we are referring this mode
separately as MOUNT_CACHED
mode, and keeping our original MOUNT
mode as it is.
This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
Tested (run the relevant ones):
bash format.sh
sky stop
andsky start
:pytest tests/test_smoke.py::test_aws_storage_mounts_with_stop --aws
pytest tests/test_smoke.py::test_gcp_storage_mounts_with_stop --gcp
sky stop
andsky start
withcomp_test.yaml
to see if all theMOUNT_CACHED
remains storage remains mounted.comp_test.yaml
:launch
tests:spot
jobs tests:launch
on docker containers:comp_test.yaml
:MOUNT_CACHED
mode can recover from preemption to continue training using our vicuna training script.MOUNT_CACHED
mode performs as much as or better than ourMOUNT
mode when writting checkpoints