Replace deprecated azure.common usages

[Programmerino]

azure.common is deprecated and throws the following error on newer version:

The public API of azure-cli-core has been deprecated starting 2.21.0, and this method can no longer return a valid credential. If you need to still use this method, you need to install 'azure-cli-core<2.21.0'. You may corrupt data if you use current CLI and old azure-cli-core.

This PR replaces the relevant code (very few places), using new APIs and CLI parsing instead (unfortunately the recommended route)

I'm not able to run smoke tests on my machine, so if someone wants to make sure the changes to the skylet code are OK, that would be good.

Tested (run the relevant ones):

• Code formatting: bash format.sh
• Any manual or new tests for this PR (please specify below)
• All smoke tests: pytest tests/test_smoke.py
• Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
• Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

[cblmemo]

Thanks for identifying this problem @Programmerino and welcome to SkyPilot! 🚀 This is exciting. Left some discussions 🫡

[Programmerino]

@cblmemo Thank you for the comments, I think this should fix the issues you mentioned. The only dubious part I see is I'm not sure if it's OK to be importing from the adapter in the skylet code, or if I should move that code somewhere else.

[cblmemo]

Thanks for the quick fix @Programmerino ! It looks mostly good to me. Left one nit about error handling. For importing adaptors in node provider, I think it should be fine but cc @Michaelvll for a double-check here :)

[cblmemo]

Should we expose the stderr here and add proper error handling? maybe raise an runtime error if json parse error and print out the error message

[cblmemo]

Thanks for the fix! Left several nits 🫡

[cblmemo]

Suggested change

	from sky.utils.subprocess_utils import run
	from sky.utils import subprocess_utils

nit: import package and modules only; https://google.github.io/styleguide/pyguide.html#2144-decision

[cblmemo]

nit: could we include those error message into the error raised instead of print it?

[cblmemo]

nit: we usually use the following context manager to disable traceback for simplicity of the output.

skypilot/sky/utils/ux_utils.py

Lines 26 to 40 in 5a0ecc7

	def print_exception_no_traceback():
	"""A context manager that prints out an exception without traceback.
	Mainly for UX: user-facing errors, e.g., ValueError, should suppress long
	tracebacks.
	If SKYPILOT_DEBUG environment variable is set, this context manager is a
	no-op and the full traceback will be shown.
	Example usage:
	with print_exception_no_traceback():
	if error():
	raise ValueError('...')
	"""

[Michaelvll]

This issue seems not happening with the latest azure-cli-2.62.0. Could you share which version of azure-cli are you using that causes the issue?

[github-actions]

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was closed because it has been stalled for 10 days with no activity.