Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] sky local up gpu support - ignore if ldconfig.real already exists #3509

Merged
merged 1 commit into from
May 6, 2024
Merged

[k8s] sky local up gpu support - ignore if ldconfig.real already exists #3509

merged 1 commit into from
May 6, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

User shared bug report on slack:

No kind clusters found.
Generating /tmp/skypilot-kind.yaml
Creating cluster "skypilot" ...
 • Ensuring node image (kindest/node:v1.21.1) 🖼  ...
 ✓ Ensuring node image (kindest/node:v1.21.1) 🖼
 • Preparing nodes 📦   ...
 ✓ Preparing nodes 📦 
 • Writing configuration 📜  ...
 ✓ Writing configuration 📜
 • Starting control-plane 🕹️  ...
 ✓ Starting control-plane 🕹️
 • Installing CNI 🔌  ...
 ✓ Installing CNI 🔌
 • Installing StorageClass 💾  ...
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-skypilot"
You can now use your cluster with:

kubectl cluster-info --context kind-skypilot

Have a nice day! 👋
Kind cluster created.

Enabling GPU support...
ln: failed to create symbolic link '/sbin/ldconfig.real': File exists

Kind node may have ldconfig.real already exist on the node. In that case symlinking is not required. This patch skips symlinking if it already exists.

Tested (run the relevant ones):

  • Manually tested with on a GCP T4 with sky local up

Michaelvll
Michaelvll approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @romilbhardwaj !

@romilbhardwaj romilbhardwaj merged commit 2ff95bb into master May 6, 2024
20 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_localup_ldconfig branch May 6, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romilbhardwaj @Michaelvll