Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Fix config syntax for IAM profile #3514

Merged
merged 5 commits into from
May 7, 2024
Merged

[AWS] Fix config syntax for IAM profile #3514

merged 5 commits into from
May 7, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 7, 2024

Fix the syntax for the AWS IAM profile introduced in #3488, so that the wildcard matching will follow the order the user specified.

from

aws:
  remote_identity:
    my-cluster1-*: my-service-account1
    my-cluster2-*: my-service-account2

to

aws:
  remote_identity:
    - my-cluster1-*: my-service-account1
    - my-cluster2-*: my-service-account2

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky jobs launch -n test echo hi --cloud aws
jobs:
  controller:
    resources:
      cloud: aws

aws:
  remote_identity:
    - sky-jobs-controller-*: SERVICE_ACCOUNT
    - "*": ray-autoscaler-v1
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll requested a review from cblmemo May 7, 2024 07:29
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. It should be ready to go after the format test passed.

docs/source/reference/config.rst Outdated Show resolved Hide resolved
sky/utils/schemas.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 904aa5c into master May 7, 2024
20 checks passed
@Michaelvll Michaelvll deleted the fix-iam-syntax branch May 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants