-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s][docs] Add feature cards for users and admins #3582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the doc @romilbhardwaj! The cards look pretty good to me! Left several comments : )
:text-align: center | ||
|
||
No complex kubernetes manifests - write a simple SkyPilot YAML and run ``sky launch``. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link for an example comparing the Kubernetes manifests vs the SkyPilot YAML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that requires a little more work since we need to work on compressing our existing YAMLs (in terms of lines of code #3594) to get a good comparison against kubernetes manifests. E.g., k8s vllm gemma manifest is 65 lines, while SkyPilot gemma is 38 lines. We should do it as a part of the K8s blog post, marked it as a TODO for now.
.. grid-item-card:: 🚯️ Minimize resource wastage | ||
:text-align: center | ||
|
||
SkyPilot can automatically terminate idle pods to free up resources for other users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that it respects user's existing kubernetes scheduling config and additionally do autodown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrased as SkyPilot can run with your custom pod scheduler and automatically terminate idle pods to free up resources for other users.
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @romilbhardwaj! LGTM.
Updates the Kubernetes docs intro to add feature cards targeted at different user personas.
TODOs