Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Fix the output skipped lines #3586

Merged
merged 55 commits into from
May 23, 2024
Merged

[UX] Fix the output skipped lines #3586

merged 55 commits into from
May 23, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 23, 2024

Blocked by #3575
In #3572, we changed the skip lines for setup command, which accidentally hide some lines in the run output. We now make the skip_lines more robust and add a smoke test for it.

Master:
sky launch -c test-output --cloud gcp --cpus 2

I 05-23 08:45:47 cloud_vm_ray_backend.py:3212] Running setup on 1 node.
Warning: Permanently added '34.134.84.60' (ECDSA) to the list of known hosts.
running setup
I 05-23 08:45:50 cloud_vm_ray_backend.py:3225] Setup completed.
I 05-23 08:45:57 cloud_vm_ray_backend.py:3314] Job submitted with Job ID: 1
INFO: Waiting for task resources on 1 node. This will block if the cluster is full.
INFO: All task resources reserved.
INFO: Reserved IPs: ['10.128.0.32']
(task, pid=3789) finish
INFO: Job finished (status: SUCCEEDED).
Shared connection to 34.134.84.60 closed.
I 05-23 08:28:19 cloud_vm_ray_backend.py:3354] Job ID: 1

This PR:

I 05-23 08:28:05 cloud_vm_ray_backend.py:3217] Running setup on 1 node.
hi
I 05-23 08:28:07 cloud_vm_ray_backend.py:3230] Setup completed.
I 05-23 08:28:13 cloud_vm_ray_backend.py:3319] Job submitted with Job ID: 2
I 05-23 08:28:15 log_lib.py:408] Start streaming logs for job 2.
INFO: Tip: use Ctrl-C to exit log streaming (task will not be killed).
INFO: Waiting for task resources on 1 node. This will block if the cluster is full.
INFO: All task resources reserved.
INFO: Reserved IPs: ['10.128.0.30']
(task, pid=6090) hi
INFO: Job finished (status: SUCCEEDED).
I 05-23 08:28:19 cloud_vm_ray_backend.py:3354] Job ID: 2

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • All smoke tests: pytest tests/test_smoke.py --kubernetes
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
    • pytest tests/test_smoke.py::test_minimal
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll requested a review from cblmemo May 23, 2024 08:48
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying and fixing this @Michaelvll ! It looks great and should be ready to go after the format test passed ;)

sky/backends/cloud_vm_ray_backend.py Outdated Show resolved Hide resolved
sky/utils/command_runner.py Outdated Show resolved Hide resolved
sky/utils/command_runner.py Outdated Show resolved Hide resolved
tests/test_smoke.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 60d0c26 into master May 23, 2024
20 checks passed
@Michaelvll Michaelvll deleted the fix-connection-output branch May 23, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants