Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Avoid base64 to prevent malware detection software misclassifying the commands #3589

Merged
merged 1 commit into from
May 26, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 23, 2024

Previously, we used base64 for the commands to be run on remote machine, which caused malware detection software to misclassify the commands as malicious. We now change it to plain text instead to get around it

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll changed the title [Core] Avoid base64 to prevent malware detection software misclassified the commands [Core] Avoid base64 to prevent malware detection software misclassifying the commands May 23, 2024
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll! Tested with a yaml containing heredoc and various escape strings in setup, works nicely.

@romilbhardwaj romilbhardwaj added this to the v0.6 milestone May 23, 2024
@Michaelvll Michaelvll merged commit 23adda4 into master May 26, 2024
20 checks passed
@Michaelvll Michaelvll deleted the avoid-base64 branch May 26, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants