Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Deactivate SkyPilot runtime env for jobs #3639

Merged
merged 4 commits into from
Jun 6, 2024
Merged

[Core] Deactivate SkyPilot runtime env for jobs #3639

merged 4 commits into from
Jun 6, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jun 5, 2024 •
edited
Loading

Fixes #3638.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch --cloud lambda --cpus 2+ which python
    • sky launch --cloud lambda task.yaml
    setup: |
  conda create -n vllm python=3.10
  conda activate vllm
  pip install vllm

run: |
  conda activate vllm
  python -m vllm.entrypoints.openai.api_server
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

concretevitamin
concretevitamin approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we run some smoke tests, maybe --aws or --gcp?

sky/skylet/log_lib.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit e4eb647 into master Jun 6, 2024
20 checks passed
@Michaelvll Michaelvll deleted the deactivate-runtime-for-job branch June 6, 2024 06:29
This was referenced Jun 7, 2024
Closed
Merged
Michaelvll added a commit that referenced this pull request Aug 23, 2024
@Michaelvll @concretevitamin
[Core] Deactivate SkyPilot runtime env for jobs (#3639)
d47b016 
* [Core] Deactivate SkyPilot runtime env for jobs

* Add smoke test for python path

* Update sky/skylet/log_lib.py

Co-authored-by: Zongheng Yang <[email protected]>

* fix

---------

Co-authored-by: Zongheng Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vLLM tutorial doesn't work (cannot find vllm module)
2 participants
@Michaelvll @concretevitamin