New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Fix --install-shell-completion when SKYPILOT_DEBUG is set #3642

Closed

Michaelvll wants to merge 1 commit into master from avoid-debug-info-for-completion

Collaborator

Michaelvll commented Jun 6, 2024 •

edited

Loading

sky --install-shell-completion auto will have the debug info in the completion script causing issue when source ~/.bashrc.

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
- export SKYPILOT_DEBUG=1; sky --install-shell-completion
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh


          [UX] Fix --install-shell-completion when SKYPILOT_DEBUG is set

bac2cd3

Michaelvll requested a review from cblmemo

June 6, 2024 03:14

Collaborator Author

Michaelvll commented Jun 6, 2024

Hmm, failed to reproduce it anymore... Closing it for now.

Michaelvll closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet