[UX] Remove warning for gcp check #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
reviewed
Jun 7, 2024
sky/clouds/gcp.py
Outdated
| @@ -742,7 +742,8 @@ def check_credentials(cls) -> Tuple[bool, Optional[str]]: | |||
| credentials, project = google.auth.default() | |||
| crm = googleapiclient.discovery.build('cloudresourcemanager', | |||
| 'v1', | |||
| credentials=credentials) | |||
| credentials=credentials, | |||
| cache_discovery=False) | |||
There was a problem hiding this comment.
Should we benchmark the performance degrade and make sure it is tolerable? I think it should be marginal though
There was a problem hiding this comment.
Yep, the performance is similar. Tested with:
python test.py
import time
from sky.adaptors import gcp
N = 20
durations = []
for _ in range(N):
start = time.time()
gcp.build('compute', 'v1', credentials=None, cache_discovery=False) # or True
end = time.time()
durations.append(end - start)
print(f'Average time to build GCP service: {sum(durations) / N:.6f} seconds')
with True
Average time to build GCP service: 0.431246 seconds
with False
Average time to build GCP service: 0.431241 seconds
Also, tested with lru_cache for gcp.build and it seems not affecting the time much.
| error = common.ProvisionerError('Operation timed out') | ||
| setattr(error, 'detailed_reason', msg) |
There was a problem hiding this comment.
Should we add an attribute for the class and assign here, instead of setattr?
There was a problem hiding this comment.
This is only used for the usage collection, which uses hasattr to check detailed_reason. Maybe we can keep it this way?
cblmemo
approved these changes
Jun 8, 2024
Michaelvll
added a commit
that referenced
this pull request
Aug 23, 2024
* remove warning for gcp check * Add detailed reason in operation failure * address comments * format * thread safty * Fix thread safety for gcp build * revert * revert * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3060
This also adds the detailed error for GCP operation in the exception raised to make it easier to debug.
Tested (run the relevant ones):
bash format.shsky check gcppytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh