[Core] Add SKYPILOT_NUM_NODES env var #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zongheng Yang <[email protected]>
Co-authored-by: Zongheng Yang <[email protected]>
Co-authored-by: Zongheng Yang <[email protected]>
concretevitamin
approved these changes
Jun 12, 2024
Michaelvll
added a commit
that referenced
this pull request
Aug 23, 2024
* Add SKYPILOT_NUM_NODES env var * Update docs/source/running-jobs/environment-variables.rst Co-authored-by: Zongheng Yang <[email protected]> * Update docs/source/running-jobs/environment-variables.rst Co-authored-by: Zongheng Yang <[email protected]> * Update docs/source/running-jobs/environment-variables.rst Co-authored-by: Zongheng Yang <[email protected]> * format * add remove version * add smoke test for num nodes * fix test --------- Co-authored-by: Zongheng Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SKYPILOT_NUM_NODESenv var as shortcut for$(echo "$SKYPILOT_NODE_IPS" | wc -l)Tested (run the relevant ones):
bash format.shsky launch --cloud gcp -c test-env --cpus 2 --num-nodes 4 'echo $SKYPILOT_NUM_NODES'sky launch --cloud gcp -c test-env --cpus 2 --num-nodes 2 'echo $SKYPILOT_NUM_NODES'pytest tests/test_smoke.py::test_inline_env tests/test_smoke.py::test_inline_env_file tests/test_smoke.py::test_managed_jobs_inline_envpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh