-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] Avoid azure reconfig everytime, speed up launch by up to 5.8x #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
changed the title
[Azure] Avoid azure reconfig everytime which reduce launch by 1.6x
[Azure] Avoid azure reconfig everytime which speed up launch by 1.6x
Jun 27, 2024
Michaelvll
changed the title
[Azure] Avoid azure reconfig everytime which speed up launch by 1.6x
[Azure] Avoid azure reconfig everytime, speed up launch by 1.6x
Jun 27, 2024
cblmemo
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @Michaelvll ! LGTM.
11 tasks
12 tasks
cblmemo
reviewed
Jun 28, 2024
Michaelvll
changed the title
[Azure] Avoid azure reconfig everytime, speed up launch by 1.6x
[Azure] Avoid azure reconfig everytime, speed up launch by up to 6x
Jun 28, 2024
Michaelvll
changed the title
[Azure] Avoid azure reconfig everytime, speed up launch by up to 6x
[Azure] Avoid azure reconfig everytime, speed up launch by up to 5.8x
Jun 28, 2024
This was referenced Jul 20, 2024
Michaelvll
added a commit
that referenced
this pull request
Aug 23, 2024
…#3697) * Avoid azure reconfig everytime * Add debug message * format * Fix error handling * format * skip deployment recreation when deployment exist * Add retry for subscription ID * fix logging * format * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates #3695.
This PR avoids an additional configuration which causes a significant slow down.
Single Node (1.6x faster)
Single Node on existing cluster (5.8x faster)
Multi Node (1.24x faster)
Tested (run the relevant ones):
bash format.sh
sky autostop -i 0 --down test-azure
sky launch -c test-azure echo hi
sky launch -c test-azure --cloud azure --cpus 2 echo hi
; manually terminate the cluster;sky down test-azure
sky launch -c test-azure --cloud azure --cpus 2 echo hi
; manually delete resource group on the portal;sky stop test-azure
(our error handling works)pytest tests/test_smoke.py --azure
(except for tests related to GPUs due to the quota limit and the issue with A10 [Core] Fix A10 GPU on Azure #3707)pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh