[Storage] Add region argument for AWS s3 upload command #3735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some of AWS regions, such as
eu-south-1
,--region
has to be provided to upload to those regions.Fixes #3405
Tested (run the relevant ones):
bash format.sh
sky launch --cloud aws --region us-west-2 test.yaml --env STORAGE_NAME=test-s3-zhwu-us-west-2
sky launch --cloud aws --region us-east-1 test.yaml --env STORAGE_NAME=test-s3-zhwu-us-east-1
sky launch --cloud aws --region eu-south-1 test.yaml --env STORAGE_NAME=test-s3-zhwu-eu-south-1
sky launch --cloud aws --use-spot test.yaml --env STORAGE_NAME=test-s3-zhwu-spot
(goes toeu-south-1
by default)sky launch --cloud aws test.yaml --env STORAGE_NAME=test-s3-zhwu-on-demand
(goes tous-east-1
by default)pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh