Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add region argument for AWS s3 upload command #3735

Closed
wants to merge 2 commits into from

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jul 8, 2024

In some of AWS regions, such as eu-south-1, --region has to be provided to upload to those regions.

Fixes #3405

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch --cloud aws --region us-west-2 test.yaml --env STORAGE_NAME=test-s3-zhwu-us-west-2
    • sky launch --cloud aws --region us-east-1 test.yaml --env STORAGE_NAME=test-s3-zhwu-us-east-1
    • sky launch --cloud aws --region eu-south-1 test.yaml --env STORAGE_NAME=test-s3-zhwu-eu-south-1
    • sky launch --cloud aws --use-spot test.yaml --env STORAGE_NAME=test-s3-zhwu-spot (goes to eu-south-1 by default)
    • sky launch --cloud aws test.yaml --env STORAGE_NAME=test-s3-zhwu-on-demand (goes to us-east-1 by default)
    envs:
      STORAGE_NAME:
    
    file_mounts:
      /dst:
        name: $STORAGE_NAME
        source: examples
        mode: MOUNT
    
    resources:
      cloud: aws
      cpus: 2
    
    run: |
      ls -al /dst | grep tpu
    
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll marked this pull request as ready for review July 8, 2024 19:45
@Michaelvll Michaelvll requested a review from romilbhardwaj July 8, 2024 19:45
@Michaelvll Michaelvll marked this pull request as draft July 9, 2024 03:01
@Michaelvll
Copy link
Collaborator Author

Michaelvll commented Jul 9, 2024

This is still problematic for sky jobs launch, due to not specifying region in places, such as
https://github.com/skypilot-org/skypilot/blob/master/sky/cloud_stores.py#L49-L69

Copy link
Contributor

github-actions bot commented Nov 7, 2024

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 7, 2024
Copy link
Contributor

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] Bucket on eu-south-1 fail to copy/mount
1 participant