Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add comparison page #3756

Merged
merged 11 commits into from
Aug 2, 2024
Merged

[docs] Add comparison page #3756

merged 11 commits into from
Aug 2, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

@romilbhardwaj romilbhardwaj commented Jul 16, 2024

Adds a page comparing SkyPilot to other systems.

TODO:

  • Need to fix the padding for the code blocks / add nicer code blocks with line numbers. To be done after all else is good.

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romilbhardwaj. Looks great. Some comments.

docs/source/docs/index.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
* **With SkyPilot, a single sky launch takes care of everything.** Behind the scenes, SkyPilot provisions pods, installs all required dependencies, executes the job, returns logs and provides SSH and VSCode access to debug.


Simpler YAMLs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking out loud, do we like this better or something like "Simpler interface and faster developer speed" (the latter is more directly a benefit)?

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments.

docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
Comparing SkyPilot with other systems
=====================================

We are often asked "How does SkyPilot compare with XYZ?". Providing an unbiased and up-to date answer for such questions is not easy, especially when the differences may be qualitative.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of feel this para is a bit odd. Seems messages aren't lost if left out. Wdyt? Cc @Michaelvll for a look too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it because comparisons can be sensitive for the authors of other systems, especially if we do not present their strengths. I think this should stay in

Copy link
Collaborator

@Michaelvll Michaelvll Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this, but may be good to rephrase a bit of the sentence. Some reference for how other library starts the comparison:

Because of this flexibility, Terraform can be used to solve many different problems. This means there are a number of existing tools that overlap with the capabilities of Terraform. We compare Terraform to a number of these tools, but it should be noted that Terraform is not mutually exclusive with other systems. It can be used to manage a single application, or the entire datacenter.
Because of this broad array of supported scenarios, there are many tools that overlap with Pulumi’s capabilities. Many of these are complementary and can be used together, whereas some are “either or” decisions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded the paragraph. wdyt?

docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this page @romilbhardwaj! This will be very important for a potential k8s user.

SkyPilot vs Vanilla Kubernetes
------------------------------

Kubernetes is a powerful system for managing containerized applications. :ref:`Using SkyPilot to access your Kubernetes cluster <kubernetes-overview>` boosts developer productivity and allows you to scale your infra beyond a single Kubernetes cluster.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we show a architecture diagram for showing how SkyPilot relates to kubernetes clusters? For example, a user interacts with SkyPilot and SkyPilot sends the requests to underlying Kubernetes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - added an architecture figure. wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


</div>
</div>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking out loud, not sure if we can think of other value adds on this page, or if we can go a bit deeper for the points we mentioned below, like what is the quantitative benefits GPU availability and Costs can provide. The current points feel a bit weak.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm we had some numbers in the earlier commits but removed them in this comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! Let's skip the numbers for now then.

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @romilbhardwaj.

docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
SkyPilot vs Vanilla Kubernetes
------------------------------

Kubernetes is a powerful system for managing containerized applications. :ref:`Using SkyPilot to access your Kubernetes cluster <kubernetes-overview>` boosts developer productivity and allows you to scale your infra beyond a single Kubernetes cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/source/reference/comparison.rst Show resolved Hide resolved
docs/source/reference/comparison.rst Outdated Show resolved Hide resolved
@romilbhardwaj
Copy link
Collaborator Author

Thanks for the reviews! Merging now.

@romilbhardwaj romilbhardwaj added this pull request to the merge queue Aug 2, 2024
Merged via the queue into master with commit 8c72a1b Aug 2, 2024
20 checks passed
@romilbhardwaj romilbhardwaj deleted the docs_comparison branch August 2, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants