[k8s] Surface provisioning errors + handling for fuse failures #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaiacai
reviewed
Jul 30, 2024
There was a problem hiding this comment.
lgtm @romilbhardwaj ! I also manually tested the insufficient cpu, memory, and gpu error messages and they look good to me. not sure how to test the FUSE error mounting so you'll need to test that error path.
sky/provision/kubernetes/instance.py
Outdated
| f'{pod.spec.node_selector[label_key]}' | ||
| ' is available in the cluster.') | ||
| raise config_lib.KubernetesError( | ||
| lack_resource_msg('GPU', pod, extra_msg, | ||
| event_message)) |
There was a problem hiding this comment.
Suggested change
| event_message)) | |
| details=event_message)) |
for consistency with the above uses of lack_resource_msg
|
Thanks @asaiacai - should be ready for another look now. Ran the tests in the PR description again. |
|
This lgtm! thanks @romilbhardwaj |
Michaelvll
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging for surfacing errors during pod provisioning due to insufficient resources.
Previously, any non-cpu/memory related failure would be shown as insufficient GPU, even though other resources may be missing.
We now surface the underlying error message and add special handling for when FUSE device is unavailable (reported by users).
Tested (run the relevant ones):
bash format.shsky launch