[FluidStack][API] Update FluidStack to new API #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update FluidStack to new API
* Simplify deployment by removing CUDA installation and using pre-built images
Co-authored-by: Mubarak Jibril <[email protected]>
Michaelvll
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Thanks for migrating the fluidstack API @mjibril! It mostly looks good to me. Please see the comments below, mostly for tests.
As we mentioned offline, we saw an issue terminating existing instances., for which we should probably fix.
mjibril
force-pushed
the
fluidstack-new-api
branch
4 times, most recently
from
e341c22 to
f02dc2f
Compare
Michaelvll
reviewed
Aug 5, 2024
Comment on lines
+3821
to
+3824
| pytest.mark.no_fluidstack | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| pytest.mark.no_fluidstack | |
| @pytest.mark.no_fluidstack |
There was a problem hiding this comment.
Also, we may want to add the same decorator for the test_skyserve_fast_update below on L3861 as well.
mjibril
force-pushed
the
fluidstack-new-api
branch
from
f02dc2f to
bd73b7d
Compare
mjibril
force-pushed
the
fluidstack-new-api
branch
from
bd73b7d to
fd25ccd
Compare
mjibril
force-pushed
the
fluidstack-new-api
branch
from
fd25ccd to
8b40139
Compare
|
Thanks for the update @mjibril and the excellent work! Just merged this PR to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.shsky launch -c test-single-instance --cloud fluidstack echo hisky checkpytest tests/test_smoke.pypytest tests/test_smoke.py --fluidstack --terminate-on-failurepytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh