[Catalog] Fix lambda fetcher #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
approved these changes
Aug 2, 2024
| @@ -71,24 +73,32 @@ def create_catalog(api_key: str, output_path: str) -> None: | |||
| # We parse info.keys() in reverse order so gpu_1x_a100_sxm4 comes before | |||
| # gpu_1x_a100 in the catalog (gpu_1x_a100_sxm4 has more availability). | |||
| for vm in reversed(list(info.keys())): | |||
| gpu = name_to_gpu(vm) | |||
| gpu_cnt = float(name_to_gpu_cnt(vm)) | |||
There was a problem hiding this comment.
The name_to_gpu_cnt function is not used and safe to delete?
| } | ||
|
|
||
|
|
||
| def name_to_gpu(name: str) -> str: | ||
| def name_to_gpu_and_cnt(name: str) -> Optional[Tuple[str, int]]: |
There was a problem hiding this comment.
could we add a comment for the expected format of the name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambda recently added CPU instance type which causes our catalog fetcher fail. This PR fixes this.
Tested (run the relevant ones):
bash format.shpython -m sky.clouds.service_catalog.data_fetchers.fetch_lambda_cloudpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh