[k8s] Show per node status in sky show-gpus #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Aug 8, 2024
Comment on lines
+1702
to
+1712
| for pod in pods: | ||
| # Get all the pods running on the node | ||
| if (pod.spec.node_name == node.metadata.name and | ||
| pod.status.phase in ['Running', 'Pending']): | ||
| # Iterate over all the containers in the pod and sum the | ||
| # GPU requests | ||
| for container in pod.spec.containers: | ||
| if container.resources.requests: | ||
| allocated_qty += int( | ||
| container.resources.requests.get( | ||
| 'nvidia.com/gpu', 0)) |
There was a problem hiding this comment.
nit: it might be interesting to show the number of running pods on each nodes as well, but this is minor if a user does not request that. : )
There was a problem hiding this comment.
Good point - though one challenge is a node may be running many pods across different namespaces.. perhaps we can show only the pods in the user's configured namespace. We can add this if users ask :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
sky show-gpus --cloud kubernetesto also show per node GPU availability information. Helps users debug out of resource errors and get better visibility into their cluster.Example:
Tested (run the relevant ones):
bash format.shManual tests: