Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkyServe][Test] Fix test_smoke.py::test_skyserve_new_autoscaler_update #3824

Merged
merged 8 commits into from
Aug 18, 2024
Merged

[SkyServe][Test] Fix test_smoke.py::test_skyserve_new_autoscaler_update #3824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
63611a2
fix test_smoke.py::test_skyserve_new_autoscaler_update
landscapepainter Aug 12, 2024
5fe603a
nit
landscapepainter Aug 12, 2024
93fbd38
format
landscapepainter Aug 12, 2024
eed43e4
move out the comment from run at new_autoscaler_after.yaml
landscapepainter Aug 15, 2024
58f34e3
revert comment
landscapepainter Aug 15, 2024
1789432
revert templating
landscapepainter Aug 17, 2024
8bc1c40
nit
landscapepainter Aug 17, 2024
ad1f941
nit
landscapepainter Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/skyserve/update/new_autoscaler_after.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ service:
base_ondemand_fallback_replicas: 1

resources:
cloud: gcp
ports: 8081
use_spot: true
cpus: 2+
Expand All @@ -22,4 +21,4 @@ run: |
# blue-green update.
sleep 120
fi
python3 server.py
python3 server.py --port 8081
3 changes: 1 addition & 2 deletions tests/skyserve/update/new_autoscaler_before.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@ service:
replicas: 2

resources:
cloud: gcp
ports: 8081
cpus: 2+

workdir: examples/serve/http_server

run: python3 server.py
run: python3 server.py --port 8081
4 changes: 2 additions & 2 deletions tests/test_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3952,7 +3952,7 @@ def test_skyserve_update_autoscale(generic_cloud: str):
@pytest.mark.parametrize('mode', ['rolling', 'blue_green'])
def test_skyserve_new_autoscaler_update(mode: str, generic_cloud: str):
"""Test skyserve with update that changes autoscaler"""
name = _get_service_name() + mode
name = f'{_get_service_name()}-{mode}'

wait_until_no_pending = (
f's=$(sky serve status {name}); echo "$s"; '
Expand Down Expand Up @@ -3982,7 +3982,7 @@ def test_skyserve_new_autoscaler_update(mode: str, generic_cloud: str):
_check_service_version(name, "1"),
]
test = Test(
'test-skyserve-new-autoscaler-update',
f'test-skyserve-new-autoscaler-update-{mode}',
[
f'sky serve up -n {name} --cloud {generic_cloud} -y tests/skyserve/update/new_autoscaler_before.yaml',
_SERVE_WAIT_UNTIL_READY.format(name=name, replica_num=2) +
Expand Down
Loading