Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Fix docker login on Azure #3831

Merged
merged 2 commits into from
Aug 15, 2024
Merged

[Azure] Fix docker login on Azure #3831

merged 2 commits into from
Aug 15, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Aug 14, 2024

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    resources:
      cloud: azure
      image_id: docker:michaelvll/skypilot-test:v4
    
    
    envs:
      SKYPILOT_DOCKER_USERNAME: michaelvll
      SKYPILOT_DOCKER_PASSWORD: "xxxx"
      SKYPILOT_DOCKER_SERVER: docker.io
    
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll marked this pull request as ready for review August 14, 2024 18:40
@Michaelvll Michaelvll requested a review from cblmemo August 14, 2024 20:24
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying and fixing this @Michaelvll ! LGTM :))

@Michaelvll Michaelvll added this pull request to the merge queue Aug 15, 2024
Merged via the queue into master with commit 6f89fa5 Aug 15, 2024
20 checks passed
@Michaelvll Michaelvll deleted the fix-azure-docker-login branch August 15, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants