[AWS] Support capacity block reservation #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
author Zhanghao Wu <[email protected]> 1724175607 +0000 committer Zhanghao Wu <[email protected]> 1724210666 +0000 wip Allow prioritize reservations format Add check reserved resources format
…g/skypilot into support-capacity-block
|
@cblmemo This is ready for a review. |
cblmemo
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #3852.This PR adds support for capacity block reservations.
We are not able to test it at the moment due to the lack of quota for creating a capacity block.Thanks a lot to @jasonkrone for the awesome instruction PR: https://github.com/skypilot-org/skypilot/pull/3818/files
Also, thanks Sherjil for helping us test this PR on real capacity block.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh