-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] Support fractional A10 instance types #3877
Merged
Merged
Changes from 8 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
de35be4
fix
cblmemo 39d6c15
change catalog to float gpu num
cblmemo 7324504
support print float point gpu in sky launch. TODO: test if the ray de…
cblmemo 347ad62
fix unittest
cblmemo 71af06e
format
cblmemo d419442
patch ray resources to ceil value
cblmemo f529689
support launch from --gpus A10
cblmemo 2031a50
only allow strictly match fractional gpu counts
cblmemo 07e47d6
address comment
cblmemo 639c686
Merge remote-tracking branch 'origin/master' into support-fractional-a10
cblmemo 4c45ff7
Merge remote-tracking branch 'origin/master' into support-fractional-a10
cblmemo 84d6d0d
change back condition
cblmemo eca7033
fix
cblmemo 0055fc1
apply suggestions from code review
cblmemo 9652119
fix
cblmemo a5c5b15
Update sky/backends/cloud_vm_ray_backend.py
cblmemo d2cff96
format
cblmemo e8e9954
fix display of fuzzy candidates
cblmemo db607fa
fix precision issue
cblmemo e98ecdc
fix num gpu required
cblmemo 8ada7a2
refactor in check_resources_fit_cluster
cblmemo f6c9fad
change type annotation of acc_count
cblmemo a1f59a0
enable fuzzy fp acc count
cblmemo bcbf5ec
Merge remote-tracking branch 'origin/master' into support-fractional-a10
cblmemo 3200d39
fix k8s
cblmemo 6e41da5
Merge remote-tracking branch 'origin/master' into support-fractional-a10
cblmemo fb3049f
Update sky/clouds/service_catalog/common.py
cblmemo 82d442f
fix integer gpus
cblmemo 84d146c
format
cblmemo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,11 +5,10 @@ | |
- Hysun He ([email protected]) @ May 4, 2023: Support use the default | ||
image_id (configurable) if no image_id specified in the task yaml. | ||
""" | ||
import json | ||
import logging | ||
import os | ||
import typing | ||
from typing import Dict, Iterator, List, Optional, Tuple | ||
from typing import Dict, Iterator, List, Optional, Tuple, Union | ||
|
||
from sky import clouds | ||
from sky import exceptions | ||
|
@@ -176,7 +175,7 @@ def get_default_instance_type( | |
def get_accelerators_from_instance_type( | ||
cls, | ||
instance_type: str, | ||
) -> Optional[Dict[str, int]]: | ||
) -> Optional[Dict[str, Union[int, float]]]: | ||
return service_catalog.get_accelerators_from_instance_type( | ||
instance_type, clouds='oci') | ||
|
||
|
@@ -196,10 +195,8 @@ def make_deploy_resources_variables( | |
|
||
acc_dict = self.get_accelerators_from_instance_type( | ||
resources.instance_type) | ||
if acc_dict is not None: | ||
custom_resources = json.dumps(acc_dict, separators=(',', ':')) | ||
else: | ||
custom_resources = None | ||
custom_resources = resources_utils.make_ray_custom_resources_str( | ||
acc_dict) | ||
|
||
image_str = self._get_image_id(resources.image_id, region.name, | ||
resources.instance_type) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message is not accurate? Our check is for ACC count of existing cluster instead of the task requested resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the above comments 🤔