Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Inform user if bash too old for shell completion #3892

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

jucor
Copy link
Contributor

@jucor jucor commented Aug 29, 2024

As discussed in #3885.

I extend the bash command that installs the shell completion to explain to the user that their bash is too old, if the version check added in #2433 fails.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below) not needed
  • All smoke tests: pytest tests/test_smoke.py none relevant
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name none relevant
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh not relevant

@jucor jucor changed the title Inform user if bash too old for shell completion [Core] Inform user if bash too old for shell completion Aug 29, 2024
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the error message @jucor! LGTM.

@Michaelvll Michaelvll added this pull request to the merge queue Sep 2, 2024
Merged via the queue into skypilot-org:master with commit 9df9689 Sep 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants