Avoid using lambda in skylet.constant
#3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Aug 29, 2024
| @@ -137,7 +135,7 @@ | |||
| # true. | |||
| '{ bash Miniconda3-Linux-x86_64.sh -b; ' | |||
| 'eval "$(~/miniconda3/bin/conda shell.bash hook)" && conda init && ' | |||
| f'conda config --set auto_activate_base {conda_auto_activate} && ' | |||
| 'conda config --set auto_activate_base {conda_auto_activate} && ' | |||
There was a problem hiding this comment.
Can we add a comment here saying that the caller should replace this conda_auto_activate with true or false?
There was a problem hiding this comment.
Good point! Added. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3874 (comment)
Just found a more elegant way to do this..
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh