Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix dumping and retry for run section #3906

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[Core] Fix dumping and retry for run section #3906

merged 1 commit into from
Sep 3, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Sep 3, 2024 •
edited
Loading

This is to fix a missing line from #3884, where we should update the command used for run section.

Fixes #3900

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll mentioned this pull request Sep 3, 2024
Closed
kesitrifork
kesitrifork reviewed Sep 3, 2024
View reviewed changes
Copy link

@kesitrifork kesitrifork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solved the problem, nice! 👍

@Michaelvll Michaelvll requested a review from cblmemo September 3, 2024 18:54
cblmemo
cblmemo approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! LGTM

@Michaelvll Michaelvll added this pull request to the merge queue Sep 3, 2024
Merged via the queue into master with commit f8c62cb Sep 3, 2024
20 checks passed
@Michaelvll Michaelvll deleted the fix-run-dump branch September 3, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesitrifork kesitrifork kesitrifork left review comments

@cblmemo cblmemo cblmemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to get started with tutorial on GCP
3 participants
@Michaelvll @cblmemo @kesitrifork