Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure][Disk] Ultra tier on Azure with disk bursting. #3944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Sep 13, 2024

This PR adds ultra tier on Azure, leveraging Azure disk bursting.

Since configure the disk bursting requires restarting the VM, which introduces ~44s overhead to the provisioning stage, we still set the best disk tier to high on Azure for now. We should investigate the attached data disk which could support Premium SSD v2 & ultra disk.

I 09-13 14:20:25 instance.py:306] Stopped instances to enable disk bursting in 23.10 seconds.
I 09-13 14:20:37 instance.py:318] Enabled disk bursting for {len(disks)} disks in 12.44 seconds.
I 09-13 14:20:46 instance.py:324] Started instances to enable disk bursting in 8.56 seconds.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch --cloud azure --disk-tier ultra --disk-size 1024 launches successfully.
    • sky launch --cloud azure --disk-tier ultra outputs error Azure Ultra SSD requires a disk size greater than 512GB.
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Contributor

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant