New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lambda] Fix internal IP regex #4072

Closed

Michaelvll wants to merge 1 commit into master from fix-lambda-internal-ips

Collaborator

Michaelvll commented Oct 11, 2024 •

edited

Loading

It seems there is a new group of internal IPs for lambda, and our regex should reflect that.

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh


          Use new internal IPs

a299194

Michaelvll mentioned this pull request

[UX] A new look of SkyPilot console outputs #4023

Merged

8 tasks

Collaborator Author

Michaelvll commented Oct 22, 2024

This is irrelevant after #3865. Closing now

Michaelvll closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet