[Storage] Show logs for storage mount

[zpoint]

Feature for #4105

• All storage object uploads will get a new temp file and log to this temp file.

(sky) ➜  skypilot git:(dev/zeping/show_logs_for_storage_mount) ✗ cat ~/Desktop/hello-sky/work_dir_2.yaml
resources:
  cloud: aws

file_mounts:
  ~/aws: ~/Desktop/dir2

  /datasets-storage:
    name: sky-dataset
    source: ~/Desktop/dir2 
    persistent: True
    mode: MOUNT

workdir: ~/Desktop/dir1

num_nodes: 1

run: |
  echo "Hello, world!"
  ls ~/aws
  ls /datasets-storage

sky jobs launch ~/Desktop/hello-sky/work_dir_2.yaml

Tested (run the relevant ones):

• Code formatting: bash format.sh
• Any manual or new tests for this PR (please specify below)
• All smoke tests: pytest tests/test_smoke.py
• Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
• Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (3)

sky/data/storage.py:1002

• The variable 'self.source' should be 'source' to match the function parameter.

logger.warning(f'\'.git\' directory under \'{self.source}\' ' 'is excluded during sync.')

sky/data/data_utils.py:541

• The error message has a grammatical error. It should be 'No file uploaded. This could be due to an error or because all files already exist on the cloud.'

storage_logger.info('No file uploaded, could be error happened or all files already exist on cloud')

sky/data/data_utils.py:531

• [nitpick] The variable name 'stdout_line_write_cnt' is not very descriptive. Consider renaming it to 'stdout_line_count'.

stdout_line_write_cnt = 0

[romilbhardwaj]

Thanks @zpoint!

[romilbhardwaj]

Thanks @zpoint! Works nicely. Should be good to go after the two comments are resolved.

[romilbhardwaj]

We should use backend_utils.get_run_timestamp() to have paths consistent with provisioning logs.

[zpoint]

I made some modifications to avoid a circular import.

[zpoint]

@romilbhardwaj Review reminder 😊

[romilbhardwaj]

Thanks @zpoint! One minor comment, should be good to go.

[romilbhardwaj]

Thanks @zpoint, lgtm!