Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Fix sky jobs logs for finished jobs #4465

Closed
wants to merge 1 commit into from
Closed

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Dec 12, 2024

sky jobs logs has an issue with finished jobs as we did not expand the log files with username. In this PR we fixed it.

To reproduce:

sky jobs launch -n jobs-logs --cloud aws --cpus 2 echo hi
sky jobs logs

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll
Copy link
Collaborator Author

Actually this is not the case. The jobs logs works fine on master. False alarm. Closing.

@Michaelvll Michaelvll closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant