Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Make node termination robust #4469

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Conversation

romilbhardwaj
Copy link
Collaborator

Makes node termination on k8s more robust by:

  1. Having separate try catch blocks for each service
  2. Adding retries for transient errors
  3. Raising non-404 errors encountered during service deletion

Tested:

  • Regular sky launch followed by sky down
  • sky down after manually deleting services

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romilbhardwaj for making this more robust! left some minor changes

sky/provision/kubernetes/instance.py Outdated Show resolved Hide resolved
sky/provision/kubernetes/instance.py Outdated Show resolved Hide resolved
@romilbhardwaj romilbhardwaj merged commit ed8e694 into master Dec 13, 2024
19 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_service_deletion branch December 13, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants