Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Azure spot instance #4475

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Dec 17, 2024

Test case for: #4423

Add test case: test_azure_spot_instance_verification

Test Azure spot instance provisioning with explicit verification.
    This test verifies that when --use-spot is specified for Azure:
    1. The cluster launches successfully
    2. The instances are actually provisioned as spot instances

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@zpoint zpoint added this to the v0.7.1 milestone Dec 17, 2024
@zpoint zpoint requested a review from Michaelvll December 17, 2024 09:16
@zpoint
Copy link
Collaborator Author

zpoint commented Dec 18, 2024

/pre-merge-test

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zpoint!

@zpoint zpoint merged commit c19e94e into skypilot-org:master Dec 19, 2024
20 checks passed
zpoint added a commit to zpoint/skypilot that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants