[aws] cache user identity by 'aws configure list' #4507
+89
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache
aws sts get-caller-identity
result, indexed by hashing the output ofaws configure list
. This will speed upsky launch
by ~1s in subsequent runs.original discussion: #3159 (comment)
A simple benchmark (enabled clouds:
[aws, gcp, azure, kubernetes, runpod, cudo, paperspace]
, the code is slightly modified to return before the confirmation is prompted):@Michaelvll Please kindly take a look
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh