PR feedback

sl-sh-dev · Jan 31, 2025 · 8ea679b · 8ea679b
1 parent 42826b9
commit 8ea679b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 90 deletions.
diff --git a/bridge_adapters/src/lisp_adapters/primitives.rs b/bridge_adapters/src/lisp_adapters/primitives.rs
@@ -18,8 +18,7 @@ impl SlFromRef<'_, Value> for bool {
             Value::True => Ok(true),
             Value::False => Ok(false),
             Value::Nil => Ok(false),
-            //TODO XXX should undefined be included here? sls what say you?
-            Value::Undefined => Ok(false),
+            Value::Undefined => panic!("Undefined is the default initialized state of a value and its presence in actual code is a VM logical error."),
             _ => Ok(true),
         }
     }

diff --git a/test-monitor-fs-changes.slosh b/test-monitor-fs-changes.slosh