Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and fix new clippies. #209

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Update deps and fix new clippies. #209

merged 2 commits into from
Dec 8, 2024

Conversation

sstanfield
Copy link
Member

No functionality, just updates devs and fixes latest clippers. Need to do this to sl-console and sl-liner as well.

@sstanfield sstanfield requested a review from gpwclark December 7, 2024 21:21
@sstanfield sstanfield self-assigned this Dec 7, 2024
Copy link
Member

@gpwclark gpwclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duly noted. i'll randomly pick sl-liner to do, but if that's harder happy to switch.

@sstanfield
Copy link
Member Author

duly noted. i'll randomly pick sl-liner to do, but if that's harder happy to switch.

@gpwclark
Was just noting that we need to hit our other deps. I don't think either will be an issue. Also, either syn or quote (forget which) for the macros need a major bump and if I remember correctly the API has changed a bit. If you want to tackle that first that would be good. I left it for now, was just cleaning bitrot/taking care of some crates with security issues.

Also benches are broken, probably because an update so I have to look at that.

Copy link

github-actions bot commented Dec 7, 2024

🐰 Bencher Report

Branchsls-updatedeps
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkEstimated Cyclesestimated cyclesInstructionsinstructionsL1 HitshitsL2 HitshitsRAM HitshitsTotal read+writereads/writes
iai::float::float_one_hundred📈 view plot
⚠️ NO THRESHOLD
133,544,208.00📈 view plot
⚠️ NO THRESHOLD
95,501,180.00📈 view plot
⚠️ NO THRESHOLD
132,346,063.00📈 view plot
⚠️ NO THRESHOLD
140,033.00📈 view plot
⚠️ NO THRESHOLD
14,228.00📈 view plot
⚠️ NO THRESHOLD
132,500,324.00
iai::float::float_one_thousand📈 view plot
⚠️ NO THRESHOLD
424,831,811.00📈 view plot
⚠️ NO THRESHOLD
312,761,980.00📈 view plot
⚠️ NO THRESHOLD
423,633,291.00📈 view plot
⚠️ NO THRESHOLD
140,073.00📈 view plot
⚠️ NO THRESHOLD
14,233.00📈 view plot
⚠️ NO THRESHOLD
423,787,597.00
iai::float::float_ten_thousand📈 view plot
⚠️ NO THRESHOLD
3,337,631,923.00📈 view plot
⚠️ NO THRESHOLD
2,485,306,399.00📈 view plot
⚠️ NO THRESHOLD
3,336,435,283.00📈 view plot
⚠️ NO THRESHOLD
139,711.00📈 view plot
⚠️ NO THRESHOLD
14,231.00📈 view plot
⚠️ NO THRESHOLD
3,336,589,225.00
iai::float::optimized_float_fifty_thousand📈 view plot
⚠️ NO THRESHOLD
8,844,242,859.00📈 view plot
⚠️ NO THRESHOLD
7,000,416,738.00📈 view plot
⚠️ NO THRESHOLD
8,844,223,689.00📈 view plot
⚠️ NO THRESHOLD
61.00📈 view plot
⚠️ NO THRESHOLD
539.00📈 view plot
⚠️ NO THRESHOLD
8,844,224,289.00
iai::float::optimized_float_one_hundred📈 view plot
⚠️ NO THRESHOLD
17,731,122.00📈 view plot
⚠️ NO THRESHOLD
14,017,400.00📈 view plot
⚠️ NO THRESHOLD
17,711,907.00📈 view plot
⚠️ NO THRESHOLD
63.00📈 view plot
⚠️ NO THRESHOLD
540.00📈 view plot
⚠️ NO THRESHOLD
17,712,510.00
iai::float::optimized_float_one_thousand📈 view plot
⚠️ NO THRESHOLD
176,926,867.00📈 view plot
⚠️ NO THRESHOLD
140,024,738.00📈 view plot
⚠️ NO THRESHOLD
176,907,687.00📈 view plot
⚠️ NO THRESHOLD
63.00📈 view plot
⚠️ NO THRESHOLD
539.00📈 view plot
⚠️ NO THRESHOLD
176,908,289.00
iai::float::optimized_float_ten_thousand📈 view plot
⚠️ NO THRESHOLD
1,768,882,901.00📈 view plot
⚠️ NO THRESHOLD
1,400,096,738.00📈 view plot
⚠️ NO THRESHOLD
1,768,863,686.00📈 view plot
⚠️ NO THRESHOLD
63.00📈 view plot
⚠️ NO THRESHOLD
540.00📈 view plot
⚠️ NO THRESHOLD
1,768,864,289.00
iai::recursion_and_continuations::continuation_vec_search_one_hundred📈 view plot
⚠️ NO THRESHOLD
105,224,926.00📈 view plot
⚠️ NO THRESHOLD
74,012,480.00📈 view plot
⚠️ NO THRESHOLD
103,890,021.00📈 view plot
⚠️ NO THRESHOLD
151,355.00📈 view plot
⚠️ NO THRESHOLD
16,518.00📈 view plot
⚠️ NO THRESHOLD
104,057,894.00
iai::recursion_and_continuations::continuation_vec_search_one_thousand📈 view plot
⚠️ NO THRESHOLD
111,226,893.00📈 view plot
⚠️ NO THRESHOLD
77,674,258.00📈 view plot
⚠️ NO THRESHOLD
109,626,278.00📈 view plot
⚠️ NO THRESHOLD
162,413.00📈 view plot
⚠️ NO THRESHOLD
22,530.00📈 view plot
⚠️ NO THRESHOLD
109,811,221.00
iai::recursion_and_continuations::continuation_vec_search_ten_thousand📈 view plot
⚠️ NO THRESHOLD
162,972,616.00📈 view plot
⚠️ NO THRESHOLD
112,047,567.00📈 view plot
⚠️ NO THRESHOLD
160,159,636.00📈 view plot
⚠️ NO THRESHOLD
232,749.00📈 view plot
⚠️ NO THRESHOLD
47,121.00📈 view plot
⚠️ NO THRESHOLD
160,439,506.00
iai::recursion_and_continuations::recursive_vec_search_one_hundred📈 view plot
⚠️ NO THRESHOLD
105,119,738.00📈 view plot
⚠️ NO THRESHOLD
73,943,229.00📈 view plot
⚠️ NO THRESHOLD
103,794,988.00📈 view plot
⚠️ NO THRESHOLD
150,038.00📈 view plot
⚠️ NO THRESHOLD
16,416.00📈 view plot
⚠️ NO THRESHOLD
103,961,442.00
iai::recursion_and_continuations::recursive_vec_search_one_thousand📈 view plot
⚠️ NO THRESHOLD
105,120,385.00📈 view plot
⚠️ NO THRESHOLD
73,939,813.00📈 view plot
⚠️ NO THRESHOLD
103,789,065.00📈 view plot
⚠️ NO THRESHOLD
151,373.00📈 view plot
⚠️ NO THRESHOLD
16,413.00📈 view plot
⚠️ NO THRESHOLD
103,956,851.00
iai::recursion_and_continuations::recursive_vec_search_ten_thousand📈 view plot
⚠️ NO THRESHOLD
156,082,798.00📈 view plot
⚠️ NO THRESHOLD
107,316,217.00📈 view plot
⚠️ NO THRESHOLD
153,523,953.00📈 view plot
⚠️ NO THRESHOLD
182,685.00📈 view plot
⚠️ NO THRESHOLD
47,012.00📈 view plot
⚠️ NO THRESHOLD
153,753,650.00
🐰 View full continuous benchmarking report in Bencher

Copy link

github-actions bot commented Dec 7, 2024

🐰 Bencher Report

Branchsls-updatedeps
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
continuation_vec_search_one_hundred📈 view plot
⚠️ NO THRESHOLD
7,263,500.00
continuation_vec_search_one_thousand📈 view plot
⚠️ NO THRESHOLD
7,636,400.00
continuation_vec_search_ten_thousand📈 view plot
⚠️ NO THRESHOLD
10,984,000.00
float_one_hundred📈 view plot
⚠️ NO THRESHOLD
9,172,800.00
float_one_thousand📈 view plot
⚠️ NO THRESHOLD
28,983,000.00
float_ten_thousand📈 view plot
⚠️ NO THRESHOLD
229,520,000.00
optimized_float_fifty_thousand📈 view plot
⚠️ NO THRESHOLD
506,670,000.00
optimized_float_one_hundred📈 view plot
⚠️ NO THRESHOLD
1,023,300.00
optimized_float_one_thousand📈 view plot
⚠️ NO THRESHOLD
10,148,000.00
optimized_float_ten_thousand📈 view plot
⚠️ NO THRESHOLD
102,370,000.00
recursive_vec_search_one_hundred📈 view plot
⚠️ NO THRESHOLD
7,269,300.00
recursive_vec_search_one_thousand📈 view plot
⚠️ NO THRESHOLD
7,579,000.00
recursive_vec_search_ten_thousand📈 view plot
⚠️ NO THRESHOLD
10,487,000.00
🐰 View full continuous benchmarking report in Bencher

@sstanfield sstanfield merged commit 78d13c2 into main Dec 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants