Allow non-string values for attributors

slab · Jan 15, 2024 · 5295b40 · 5295b40
1 parent 1dde5ed
commit 5295b40
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/src/attributor/attributor.ts b/src/attributor/attributor.ts
@@ -29,7 +29,7 @@ export default class Attributor {
     }
   }
 
-  public add(node: HTMLElement, value: string): boolean {
+  public add(node: HTMLElement, value: any): boolean {
     if (!this.canAdd(node, value)) {
       return false;
     }
@@ -52,7 +52,7 @@ export default class Attributor {
     node.removeAttribute(this.keyName);
   }
 
-  public value(node: HTMLElement): string {
+  public value(node: HTMLElement): any {
     const value = node.getAttribute(this.keyName);
     if (this.canAdd(node, value) && value) {
       return value;

diff --git a/src/attributor/class.ts b/src/attributor/class.ts
@@ -14,7 +14,7 @@ class ClassAttributor extends Attributor {
       .map((name) => name.split('-').slice(0, -1).join('-'));
   }
 
-  public add(node: HTMLElement, value: string): boolean {
+  public add(node: HTMLElement, value: any): boolean {
     if (!this.canAdd(node, value)) {
       return false;
     }
@@ -33,7 +33,7 @@ class ClassAttributor extends Attributor {
     }
   }
 
-  public value(node: HTMLElement): string {
+  public value(node: HTMLElement): any {
     const result = match(node, this.keyName)[0] || '';
     const value = result.slice(this.keyName.length + 1); // +1 for hyphen
     return this.canAdd(node, value) ? value : '';

diff --git a/src/attributor/style.ts b/src/attributor/style.ts
@@ -17,7 +17,7 @@ class StyleAttributor extends Attributor {
     });
   }
 
-  public add(node: HTMLElement, value: string): boolean {
+  public add(node: HTMLElement, value: any): boolean {
     if (!this.canAdd(node, value)) {
       return false;
     }
@@ -34,7 +34,7 @@ class StyleAttributor extends Attributor {
     }
   }
 
-  public value(node: HTMLElement): string {
+  public value(node: HTMLElement): any {
     // @ts-expect-error Fix me later
     const value = node.style[camelize(this.keyName)];
     return this.canAdd(node, value) ? value : '';

diff --git a/tests/types/attributor.test-d.ts b/tests/types/attributor.test-d.ts
@@ -0,0 +1,12 @@
+import { assertType } from 'vitest';
+import { ClassAttributor } from '../../src/parchment';
+
+class IndentAttributor extends ClassAttributor {
+  value(node: HTMLElement) {
+    return parseInt(super.value(node), 10) || undefined;
+  }
+}
+
+assertType<any>(
+  new IndentAttributor('indent', 'indent').value(document.createElement('div')),
+);