Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and Serve CJS Main Entry File #4467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahebou-sc
Copy link

@ahebou-sc ahebou-sc commented Oct 28, 2024

Problem:
Source issue: Not Support for CJS #4463
Trying to use the Quill package as a rich text editor but facing errors from Jest no longer parsing our files because the node module from Quill is no longer being sent out as CJS. Can we add support for CJS as well as ESM, instead of just ESM node modules? The figures below highlight this:
image
image

Solution:

  1. Change the main directory to the generated distributed CJS quill file.
  2. Add the build script post installation to generate the CJS quill file.

@ahebou-sc ahebou-sc changed the title FIX: Change main folder to the dist location, added build script post… Build and Serve CJS Main Entry File Oct 28, 2024
@ahebou-sc ahebou-sc marked this pull request as ready for review October 28, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant